feat(LabelGroup): render as list by default #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9675ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…5-prclabelgroup-component-lacks-semantic-structure
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…acks-semantic-structure
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
🟢 golden-jobs completed with status |
…acks-semantic-structure
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/348056 |
francinelucca
added
integration-tests: passing
camertron
approved these changes
Oct 30, 2024
| <StyledLabelGroupContainer data-overflow="inline" data-list={isList || undefined} sx={sxProp} as={as}> | ||
| {isList | ||
| ? React.Children.map(children, child => { | ||
| return <li>{child}</li> |
There was a problem hiding this comment.
Do these need a key prop?
There was a problem hiding this comment.
Yes! done , Thanks!!
…5-prclabelgroup-component-lacks-semantic-structure
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
deleted the
francinelucca/3425-prclabelgroup-component-lacks-semantic-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/3425
Renders the
LabelGroupas aulwithlis by default, with the option to useasprop to customize the element type of the rendered container. In the case other thanulorol, the children will be rendered asspan.Changelog
New
asprop inLabelGroupto customize container element (provides backwards compatibility)ulinLabelGroupdata-listattribute inStyledLabelGroupContainer(used to apply styles conditionally)LabelGroupchildren now wrapped by<li></li>component when rendered as listLabelGrouptests to account for new functionality and use casesChanged
LabelGrouprenders as aulby default, with option to override default implementation viaasprop.Rollout strategy
Testing & Reviewing
Check DOM in deployed story
, verify it renders as a
ulwithlis. No visual regressions should be present.Merge checklist